Change in osmo-gsm-tester[master]: iperf3: add config to adjust the duration of the iperf run

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 )

Change subject: iperf3: add config to adjust the duration of the iperf run
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/6/src/osmo_gsm_tester/iperf3.py 
File src/osmo_gsm_tester/iperf3.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/6/src/osmo_gsm_tester/iperf3.py@158 
PS6, Line 158:         if time_sec is not None:
if time_sec is None:


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/6/src/osmo_gsm_tester/iperf3.py@159 
PS6, Line 159:             values = dict(iperf3cli=config.get_defaults('iperf3cli'))
You can really drop the iperf3cli dictionary here, since it's not really useful at all:
values = config.get_defaults('iperf3cli')
config.overlay(values, self.suite_run.config())
time_sec_str = values.get('time', time_sec)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iff28816f83670751e9e91de31ec59b1b0ad8fc0d
Gerrit-Change-Number: 17651
Gerrit-PatchSet: 6
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 13:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200331/bb2075ef/attachment.htm>