Change in osmo-gsm-tester[master]: iperf3: add modifier to adjust the duration of the iperf run

[srs_andre]

srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 )

Change subject: iperf3: add modifier to adjust the duration of the iperf run
......................................................................


Patch Set 3:

(4 comments)

Below is the comment, question I had regarding the iperf modifier

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py 
File src/osmo_gsm_tester/iperf3.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py@157 
PS2, Line 157:     def prepare_test_proc(self, downlink=False, netns=None, time_sec=10):
> What about having time_sec=None by default,and if !None is passed by test then override what comes f […]
Ack


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py@160 
PS2, Line 160:         time_sec_str = values['iperf3cli'].get('time', time_sec)
Pau, the only issue with this part is that only the default value of time is available at this stage. Am I right that I have to extend the iperf class to also get the conf from the suite? Or how can I retrieve the values from the command line modifiers?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py@163 
PS2, Line 163:         if 'h' in time_sec_str:
> if time_sec_str.endswith('h') […]
Ack


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py@174 
PS2, Line 174:         self.log('Starting iperf3-client connecting to %s:%d (time=%ds)' % (self.server.addr(), self.server.port(), time_sec_final))
> Not "Starting" here, but "Preparing"
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iff28816f83670751e9e91de31ec59b1b0ad8fc0d
Gerrit-Change-Number: 17651
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 10:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200331/8eeb309e/attachment.htm>