This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17593 ) Change subject: mobile: add audio config, with unused audio loopback setting ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg File doc/examples/mobile/multi_ms.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg@63 PS2, Line 63: io-target none io-target sounds confusing. What about audio "route/routing" concept as in alsa? https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@1538 PS2, Line 1538: vty_out(vty, " no io-target%s", VTY_NEWLINE); why there's a "no"? simply have io-target none. And if it's the default, then don't print it. https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2780 PS2, Line 2780: "no io-target", NO_STR "Disable TCH frame processing") You can drop this one, rather have a io-target none -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a Gerrit-Change-Number: 17593 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2020 17:04:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200330/f9076479/attachment.htm>