Change in osmo-ttcn3-hacks[master]: library/BSSGP_Types: use tr_MI_IMSI from library/L3_Templates

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Mar 29 14:28:42 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17642 )

Change subject: library/BSSGP_Types: use tr_MI_IMSI from library/L3_Templates
......................................................................

library/BSSGP_Types: use tr_MI_IMSI from library/L3_Templates

Change-Id: Ibb02c1c545418bef34ee1e42d34857bda655e12f
---
M library/BSSGP_Types.ttcn
1 file changed, 2 insertions(+), 13 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/BSSGP_Types.ttcn b/library/BSSGP_Types.ttcn
index e9984d8..c54f708 100644
--- a/library/BSSGP_Types.ttcn
+++ b/library/BSSGP_Types.ttcn
@@ -14,6 +14,7 @@
 	import from Osmocom_Types all;
 	import from GSM_Types all;
 	import from GSM_RR_Types all;
+	import from L3_Templates all;
 	import from BSSGP_Helper_Functions all;
 
 	type enumerated BssgpPduType {
@@ -386,19 +387,7 @@
 	template BssgpTLV t_BSSGP_IE_Imsi(template hexstring imsi) := {
 		iei := IMSI,
 		len := 4,
-		u := {
-			mobile_id := {
-				typeOfIdentity := MI_TYPE_IMSI,
-				oddEvenInd_identity := {
-					imsi := {
-						/* TODO: introduce generic tr_IMSI_L3 */
-						oddevenIndicator := true, /* IMSI has 15 digits */
-						digits := imsi,
-						fillerDigit := '1111'B
-					}
-				}
-			}
-		}
+		u := { mobile_id := tr_MI_IMSI(imsi) }
 	}
 
 	template BssgpTLV t_BSSGP_IE_Qos(BssgpQosProfile qos) := {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17642
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibb02c1c545418bef34ee1e42d34857bda655e12f
Gerrit-Change-Number: 17642
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200329/8affa4cd/attachment.htm>


More information about the gerrit-log mailing list