This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
keith gerrit-no-reply at lists.osmocom.orgkeith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17647 ) Change subject: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging. ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/17647/3/src/utils/meas_json.c File src/utils/meas_json.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17647/3/src/utils/meas_json.c@176 PS3, Line 176: .name = "MEAS_JSON", > I think we never user underscores or alike in names (I may be wrong tough). […] I do not know answers to those questions. I see more now what this is actually doing. Will copy a more simple logging init from somewhere. https://gerrit.osmocom.org/c/osmo-bsc/+/17647/3/src/utils/meas_json.c@178 PS3, Line 178: .loglevel = LOGL_DEBUG, > debug doesn't sound like a good default. Probably bettee using NOTICE here. Sure. https://gerrit.osmocom.org/c/osmo-bsc/+/17647/3/src/utils/meas_json.c@191 PS3, Line 191: log_init(&log_info, NULL); > where does this functon come from? It should be osmo_init_logging2(tall_ctx, &log_info); OK I subsequently found osmo_init_logging, but FYI, the code i copied more or less was from http://git.osmocom.org/libosmocore/tree/tests/fsm/fsm_test.c#n412 Similar code is also found elsewhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib3b3558723682defcee22e7ea2d8bf5c2cff1278 Gerrit-Change-Number: 17647 Gerrit-PatchSet: 3 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 28 Mar 2020 19:16:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200328/f7b6df22/attachment.htm>