Change in osmo-gsm-tester[master]: iperf3: add modifier to adjust the duration of the iperf run

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 )

Change subject: iperf3: add modifier to adjust the duration of the iperf run
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py 
File src/osmo_gsm_tester/iperf3.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py@157 
PS2, Line 157:     def prepare_test_proc(self, downlink=False, netns=None, time_sec=10):
What about having time_sec=None by default,and if !None is passed by test then override what comes from config?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py@163 
PS2, Line 163:         if 'h' in time_sec_str:
if time_sec_str.endswith('h')
  time_sec_final = int(time_sec_str[:-1]) *3600

And probably add a new TIME_DURATION type in schema where everything's well validated.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/iperf3.py@174 
PS2, Line 174:         self.log('Starting iperf3-client connecting to %s:%d (time=%ds)' % (self.server.addr(), self.server.port(), time_sec_final))
Not "Starting" here, but "Preparing"


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/resource.py 
File src/osmo_gsm_tester/resource.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/2/src/osmo_gsm_tester/resource.py@117 
PS2, Line 117:         'iperf3cli[].time': schema.STR,
schema.TIME_DURATION,
 then add it in afair schema.py



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iff28816f83670751e9e91de31ec59b1b0ad8fc0d
Gerrit-Change-Number: 17651
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 28 Mar 2020 17:24:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200328/e61f1476/attachment.htm>