Change in osmo-pcu[master]: tbf.cpp: Include c++ <new> header required for new operator's replace...

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17625 )

Change subject: tbf.cpp: Include c++ <new> header required for new operator's replacement type
......................................................................

tbf.cpp: Include c++ <new> header required for new operator's replacement type

Including the <new> header is required as explained by the c++ specs [1]

osmo-pcu/src/tbf.cpp: In function ‘gprs_rlcmac_ul_tbf* tbf_alloc_ul_tbf(gprs_rlcmac_bts*, GprsMs*, int8_t, uint8_t, uint8_t, bool)’:
osmo-pcu/src/tbf.cpp:1002:39: error: no matching function for call to ‘operator new(sizetype, gprs_rlcmac_ul_tbf*&)’
 1002 |  new (tbf) gprs_rlcmac_ul_tbf(bts->bts);
      |                                       ^

Most of the times this issue is not detected because other STL headers
are already including <new>.

[1] http://www.cplusplus.com/reference/new/operator%20new/

Change-Id: Ie5fb536ae29dcf40e2a0dbe67432bebd61b8c7aa
---
M src/tbf.cpp
M tests/ms/MsTest.cpp
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/tbf.cpp b/src/tbf.cpp
index 444cec0..9cba354 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -19,6 +19,8 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
  */
 
+#include <new>
+
 #include <bts.h>
 #include <tbf.h>
 #include <tbf_dl.h>
diff --git a/tests/ms/MsTest.cpp b/tests/ms/MsTest.cpp
index 0c5ab9e..b5e30fb 100644
--- a/tests/ms/MsTest.cpp
+++ b/tests/ms/MsTest.cpp
@@ -40,6 +40,8 @@
 #include <errno.h>
 #include <unistd.h>
 
+#include <new>
+
 void *tall_pcu_ctx;
 int16_t spoof_mnc = 0, spoof_mcc = 0;
 bool spoof_mnc_3_digits = false;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17625
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie5fb536ae29dcf40e2a0dbe67432bebd61b8c7aa
Gerrit-Change-Number: 17625
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200327/791c591e/attachment.htm>