This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17618 ) Change subject: pdch: fix packet_paging_request(): properly print paging MI ...................................................................... pdch: fix packet_paging_request(): properly print paging MI This problem problem was discovered by the Undefined Behavior Sanitizer: pdch.cpp:210:4: runtime error: load of misaligned address 0x60c00002abf2 for type 'uint32_t', which requires 4 byte alignment Do not convert TMSI to number, use osmo_mi_name() from libosmocore. Also use this function to print other MI types (IMSI or IMEISV). Change-Id: Icf8836f216793e342b239c8e6645aac1e82bf324 --- M src/pdch.cpp 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/pdch.cpp b/src/pdch.cpp index 519028d..9910974 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -39,6 +39,7 @@ extern "C" { #include <osmocom/core/talloc.h> #include <osmocom/core/msgb.h> +#include <osmocom/gsm/gsm48.h> #include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/core/bitvec.h> #include <osmocom/core/gsmtap.h> @@ -204,11 +205,12 @@ /* loop until message is full */ while (pag) { + LOGP(DRLCMAC, LOGL_DEBUG, "Paging MI - %s\n", + osmo_mi_name(pag->identity_lv + 1, pag->identity_lv[0])); + /* try to add paging */ if ((pag->identity_lv[1] & 0x07) == 4) { /* TMSI */ - LOGP(DRLCMAC, LOGL_DEBUG, "- TMSI=0x%08x\n", - ntohl(*((uint32_t *)(pag->identity_lv + 1)))); len = 1 + 1 + 1 + 32 + 2 + 1; if (pag->identity_lv[0] != 5) { LOGP(DRLCMAC, LOGL_ERROR, "TMSI paging with " @@ -217,9 +219,6 @@ } } else { /* MI */ - LOGP(DRLCMAC, LOGL_DEBUG, "- MI=%s\n", - osmo_hexdump(pag->identity_lv + 1, - pag->identity_lv[0])); len = 1 + 1 + 1 + 4 + (pag->identity_lv[0]<<3) + 2 + 1; if (pag->identity_lv[0] > 8) { LOGP(DRLCMAC, LOGL_ERROR, "Paging with " -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf8836f216793e342b239c8e6645aac1e82bf324 Gerrit-Change-Number: 17618 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200327/b6ea4f04/attachment.htm>