Change in osmo-bsc[master]: VTY: let all descriptions end in \n

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Mar 27 09:35:55 UTC 2020


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17636 )

Change subject: VTY: let all descriptions end in \n
......................................................................


Patch Set 1:

> do we have to re-generate the VTY reference as a result?

Not because of the \n change, but in general it was outdated with the fail-report VTY command and previous VTY changes missing in the generated file. I'll make a note to regenerate it after making changes in the future and add a new, separate commit to update the VTY reference (because it is missing more than one VTY command now).

It would be great if we had some sort of CI check for that, but I know that this had been worked on, that it's not so trivial and that in general we don't have time for this now.

> Was there any malfunction connected to the lack of \n?

No, but it lead me to add new code with the missing \n and so Pau suggested to create a separate patch to fix the existing ones too for consistency.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17636
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I00a183078679db50567286a78c9e4f9afa3466c6
Gerrit-Change-Number: 17636
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 27 Mar 2020 09:35:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200327/afc23ba8/attachment.htm>


More information about the gerrit-log mailing list