Change in osmo-trx[master]: doc: do not set the base-port of the trx

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Mar 27 09:26:34 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17595 )

Change subject: doc: do not set the base-port of the trx
......................................................................


Patch Set 2: Code-Review+2

> Patch Set 1: Code-Review-1
> 
> I am sorry, but what's the point of this change? I believe the configuration examples should contain all available options, so there is no need to refer documentation / source code every time you need to remember position / format of some option. Look at configuration examples of srsLTE - everything is listed and documented there, so you don't have to leave your text editor at all.

But this is exactly not how we deal with configuration in osmocom.
* we do have compile-time default
* even a 'write file' doesn't save all values, only those that differ from default
* we do not rely on text editing of config files but have the VTY to interactively change it

Yes, this has it's problems and it can be debated.  But then please start a related issue or mailing list thread for the discussion, and at the end of that we change all of the codebase.  This specific issue is bringing the config file example in-line with the existing practice.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17595
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I105d1c51424836daa6893e83a81c83cc7ac6afd4
Gerrit-Change-Number: 17595
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 27 Mar 2020 09:26:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200327/ff0deefb/attachment.htm>


More information about the gerrit-log mailing list