Change in osmo-pcu[master]: rlcmac: support decode FDD_CELL_INFORMATION of "UTRAN FDD Description

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 26 20:21:29 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17628 )

Change subject: rlcmac: support decode FDD_CELL_INFORMATION of "UTRAN FDD Description
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/csn1.c 
File src/csn1.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/csn1.c@1438 
PS1, Line 1438: (%p)
> Printing pointer address is not a good idea since we match debug output in the unit test. […]
ack, will change.


https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/gsm_rlcmac.c 
File src/gsm_rlcmac.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/17628/1/src/gsm_rlcmac.c@2647 
PS1, Line 2647: for( i=0; i<16; i++, pCell_Sel_Param++ )
> Since you're squashing some changes anyway, please fix this fancy formatting too.
I'm keeping same wireshark content in this function, so let's leave it this way.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17628
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I08523bc1bbdffde479ef974b4c7b56cfa5639591
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Mar 2020 20:21:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200326/5a6d72ab/attachment.htm>


More information about the gerrit-log mailing list