Change in osmo-pcu[master]: Move gsm_rlcmac.cpp -> .c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Mar 26 18:50:21 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17627 )

Change subject: Move gsm_rlcmac.cpp -> .c
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/17627/1/src/decoding.h 
File src/decoding.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17627/1/src/decoding.h@21 
PS1, Line 21: extern "C" {
Please add new lines before and after this block.


https://gerrit.osmocom.org/c/osmo-pcu/+/17627/1/src/gsm_rlcmac.c 
File src/gsm_rlcmac.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/17627/1/src/gsm_rlcmac.c@39 
PS1, Line 39: assert
BTW, we should start using OSMO_ASSERT. Maybe in a separate change.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17627
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I818a8ae947f002d35142f9f5473454cfd80e1830
Gerrit-Change-Number: 17627
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 26 Mar 2020 18:50:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200326/ac5761ed/attachment.htm>


More information about the gerrit-log mailing list