Change in osmo-bsc[master]: abis_nm: move fail report parsing to extra func

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Mar 26 13:52:17 UTC 2020


Hello pespin, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-bsc/+/17588

to look at the new patch set (#3).

Change subject: abis_nm: move fail report parsing to extra func
......................................................................

abis_nm: move fail report parsing to extra func

Separate raw input parsing from handling the failure report. A follow-up
patch will use the new parsing function to print saved failure reports
to the VTY.

While at it, put struct tlv_parsed inside struct nm_fail_rep_signal_data
instead of a pointer, so we don't need an additional alloc. Also add
error handling to the abis_nm_tlv_parse() call.

Related: OS#1605
Change-Id: Ia51004faf620aa4d40435d58c70d758c9d0054d8
---
M include/osmocom/bsc/abis_nm.h
M include/osmocom/bsc/signal.h
M src/osmo-bsc/abis_nm.c
3 files changed, 64 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/17588/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17588
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia51004faf620aa4d40435d58c70d758c9d0054d8
Gerrit-Change-Number: 17588
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200326/b415e968/attachment.htm>


More information about the gerrit-log mailing list