This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17571 ) Change subject: VTY: add show bts failure report ...................................................................... Patch Set 3: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/17571/3/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17571/3/src/osmo-bsc/abis_nm.c@421 PS3, Line 421: entry->mb = msgb_copy_c(entry, mb, "OML failure report"); copy_c? is this going to be freed after mainloop iteration? https://gerrit.osmocom.org/c/osmo-bsc/+/17571/3/src/osmo-bsc/abis_nm.c@422 PS3, Line 422: list = &bts->oml_fail_rep; Drop this variable, it makes stuff more confusing that helping, since later on it's confusing with the "list" attribute of "struct bts_oml_fail_rep". https://gerrit.osmocom.org/c/osmo-bsc/+/17571/3/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17571/3/src/osmo-bsc/bsc_vty.c@579 PS3, Line 579: list = &bts->oml_fail_rep; Again, drop this variable. https://gerrit.osmocom.org/c/osmo-bsc/+/17571/3/src/osmo-bsc/bsc_vty.c@606 PS3, Line 606: When is this list cleared or getting smaller? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I18aa17a721cd5eb1c98926dc2367229c0a50bc78 Gerrit-Change-Number: 17571 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 24 Mar 2020 14:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200324/1e9eba33/attachment.htm>