Change in osmo-gsm-tester[master]: srs_enb: add num_cells param to srsENB

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17583 )

Change subject: srs_enb: add num_cells param to srsENB
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17583/2/src/osmo_gsm_tester/srs_enb.py 
File src/osmo_gsm_tester/srs_enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17583/2/src/osmo_gsm_tester/srs_enb.py@253 
PS2, Line 253:     def num_cells(self):
Avoid adding getter for no good reason if nobody's going to use them. Let's try keeping the APIs at the minimum necessary so that other object implementation don't need to provide them too later.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17583/2/src/osmo_gsm_tester/templates/srsenb_rr.conf.tmpl 
File src/osmo_gsm_tester/templates/srsenb_rr.conf.tmpl:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17583/2/src/osmo_gsm_tester/templates/srsenb_rr.conf.tmpl@89 
PS2, Line 89: % if enb.get('num_cells') == '2':
We could change all this into a for loop at some point. Fyi counter of the loop is available as ${loop.index}. Eg:
%for trx in osmo_bts_octphy.trx_list:
 trx ${loop.index}
%endfor



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17583
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I6d1658bf820163aee03b64b0f4ac68046c243f37
Gerrit-Change-Number: 17583
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 24 Mar 2020 14:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200324/5f2560be/attachment.htm>