Change in osmo-gsm-tester[master]: srs_ue: run srsUE as normal RemoteProcess

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Andre Puschmann gerrit-no-reply at lists.osmocom.org
Mon Mar 23 19:53:55 UTC 2020


Andre Puschmann has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17562 )

Change subject: srs_ue: run srsUE as normal RemoteProcess
......................................................................

srs_ue: run srsUE as normal RemoteProcess

running with RemoteProcessFixIgnoreSIGHUP was needed bc
srsUE used to ignore SIGHUP that is delivered to the process
when the SSH session is terminated causing the UE to not
quit properly. This isn't the case anymore so we can use
RemoteProcess for spawning the UE.

Furthermore, the wrapper script didn't pass along stdin
to it's child process, i.e., srsUE. Therefore the console
trace can't be seen if the run through the wrapper.

Change-Id: Iab4dafc58167620362a36ec9e904b8d49a7d5fc1
---
M src/osmo_gsm_tester/srs_ue.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/srs_ue.py b/src/osmo_gsm_tester/srs_ue.py
index 388fbf1..fdcd6dd 100644
--- a/src/osmo_gsm_tester/srs_ue.py
+++ b/src/osmo_gsm_tester/srs_ue.py
@@ -170,7 +170,7 @@
                 '--pcap.filename=' + self.remote_pcap_file,
                 '--general.metrics_csv_filename=' + self.remote_metrics_file)
 
-        self.process = self.rem_host.RemoteProcessFixIgnoreSIGHUP(srsUE.BINFILE, util.Dir(srsUE.REMOTE_DIR), args)
+        self.process = self.rem_host.RemoteProcess(srsUE.BINFILE, args)
         #self.process = self.rem_host.RemoteProcessFixIgnoreSIGHUP(srsUE.BINFILE, remote_run_dir, args, remote_lib)
         self.suite_run.remember_to_stop(self.process)
         self.process.launch()

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17562
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iab4dafc58167620362a36ec9e904b8d49a7d5fc1
Gerrit-Change-Number: 17562
Gerrit-PatchSet: 4
Gerrit-Owner: Andre Puschmann <andre at softwareradiosystems.com>
Gerrit-Reviewer: Andre Puschmann <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200323/a4d52f50/attachment.htm>


More information about the gerrit-log mailing list