Change in osmo-bsc[master]: abis_nm.c: rx_fail_evt_rep: fix sd.bts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Mar 23 12:45:47 UTC 2020


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17569 )

Change subject: abis_nm.c: rx_fail_evt_rep: fix sd.bts
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/17569/1/src/osmo-bsc/abis_nm.c 
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/17569/1/src/osmo-bsc/abis_nm.c@402 
PS1, Line 402: 	sd.bts = bts;
> The important question is: why does not it point to the BTS?
rx_fail_evt_rep(mb, bts) is called by abis_nm_rcvmsg_report(mb, bts), which is called by abis_nm_rcvmsg_fom(mb). abis_nm_rcvmsg_fom(mb) saves the extra bts pointer with a comment noting, that osmo_signal_dispatch may free mb->dst. That seems somewhat related... https://git.osmocom.org/osmo-bsc/commit/?id=74b2028167ddf04a867ae9f269bfa3435c93f252

But I'm not so familiar with the code, maybe laforge or fixeria know a better answer?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17569
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie61512f5690763fa380bdf0e7fb4763dbda019d2
Gerrit-Change-Number: 17569
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Mar 2020 12:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200323/38a94cfd/attachment.htm>


More information about the gerrit-log mailing list