Change in osmo-bts[master]: trx: Use NOPE indications from OsmoTRX for TCH/F and TCH/H

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Mar 22 17:17:20 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17566 )

Change subject: trx: Use NOPE indications from OsmoTRX for TCH/F and TCH/H
......................................................................


Patch Set 1: Code-Review+1

20:41 < fixeria> Have you seen https://gerrit.osmocom.org/c/osmo-bts/+/17539 ?
20:41 < fixeria> I think we should just get rid of the rx_nope_fn and call the uplink handler from trx_sched_ul_burst().
20:43 < fixeria> LaF0rge: back then I thought that handling of NOPE indications should be done somehow in a different way (that's why rx_nope_fn was introduced)
20:44 < fixeria> but as it turns out, calling generic ul_fn works just fine
[...]
21:05 <@LaF0rge> yes, we can get rid of it, I just wanted to do it step by step
21:06 <@LaF0rge> it's just nicer in the commitlog if we first add it everwhere and then remove it everywhere.

I still don't see how would this make the commit log nicer, given that the mentioned change by dexter will revert it... But I am definitely not against this change. At least we can fix the problem faster this way, while #17539 still needs some rework.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17566
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0fbf4617daf24bd8aecfd9cfe1efd66cf73a277a
Gerrit-Change-Number: 17566
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 22 Mar 2020 17:17:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200322/82c9a452/attachment.htm>


More information about the gerrit-log mailing list