Change in osmo-pcu[master]: rlcmac: Reproduce and fix stack smashing bug receiving RA cap

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Mar 21 01:45:37 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17548 )

Change subject: rlcmac: Reproduce and fix stack smashing bug receiving RA cap
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/17548/3/src/gsm_rlcmac.h 
File src/gsm_rlcmac.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17548/3/src/gsm_rlcmac.h@1230 
PS3, Line 1230: ABSOLUTE_MAX_BANDS
BTW, where this limitation is coming from? Any spec. references?

I see 15 different bands in AccessTechnology_t. What if a phone would send us 4? OsmoPCU would crash again :/


https://gerrit.osmocom.org/c/osmo-pcu/+/17548/3/tests/rlcmac/RLCMACTest.cpp 
File tests/rlcmac/RLCMACTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17548/3/tests/rlcmac/RLCMACTest.cpp@457 
PS3, Line 457: decoding of MS RA Capability
Please concretise that this is multi-RAT (or multi-band) MS RA Capability. Otherwise the logs are looking confusing:

=== Test decoding of MS RA Capability ===
...
=== Test decoding of MS RA Capability ===
...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17548
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5334eaacfbc238fae8bea50c9e9667c2117f81ff
Gerrit-Change-Number: 17548
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 21 Mar 2020 01:45:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200321/45180611/attachment.htm>


More information about the gerrit-log mailing list