Change in osmo-gsm-tester[master]: make sure to only use a single PHY thread when running with ZMQ

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17537 )

Change subject: make sure to only use a single PHY thread when running with ZMQ
......................................................................


Patch Set 1: Code-Review-2

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17537/1/src/osmo_gsm_tester/srs_enb.py 
File src/osmo_gsm_tester/srs_enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17537/1/src/osmo_gsm_tester/srs_enb.py@155 
PS1, Line 155:                 '--expert.nof_phy_threads=1' if self._conf.get('rf_dev_type') == 'zmq' else '')
Apply it for start_locally() too.
I think it actually makes sense to remove it from here and apply it directly on the config template file to avoid having to duplicate it in start_locally().


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17537/1/src/osmo_gsm_tester/srs_ue.py 
File src/osmo_gsm_tester/srs_ue.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17537/1/src/osmo_gsm_tester/srs_ue.py@168 
PS1, Line 168:                 '--phy.nof_phy_threads=1' if self._conf.get('rf_dev_type') == 'zmq' else '',
Same as per srs_enb.py



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17537
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ib7c7c0ff4c2d83cc51cca9a630921470a2084850
Gerrit-Change-Number: 17537
Gerrit-PatchSet: 1
Gerrit-Owner: Andre Puschmann <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2020 16:09:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200320/bed98339/attachment.htm>