Change in libosmocore[master]: dtx: add decoding for AMR-DTX frames

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Mar 19 09:05:28 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17095 )

Change subject: dtx: add decoding for AMR-DTX frames
......................................................................


Patch Set 10: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_amr_dtx.c 
File src/coding/gsm0503_amr_dtx.c:

https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_amr_dtx.c@228 
PS10, Line 228: static inline bool detect_afs_sid_first(int *n_errors, int *n_bits_total, const ubit_t *ubits)
I would argue you can remove all that explicit 'inline'.  The functions are static anyway, and the compiler will figure out the inlining by itself.


https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_coding.c 
File src/coding/gsm0503_coding.c:

https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_coding.c@2203 
PS10, Line 2203: if (*dtx == AFS_SID_UPDATE) 
style-wise, I would have used a switch (*dtx) here, but please don't change it now, just mentioning it.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17095
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2bbdb39ea20461ca08b2e6f1a33532cb55cd5195
Gerrit-Change-Number: 17095
Gerrit-PatchSet: 10
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Mar 2020 09:05:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200319/4b124de8/attachment.htm>


More information about the gerrit-log mailing list