This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17523 ) Change subject: Move parsing of GID1 to generic Card class ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/pysim/+/17523/1/pySim-read.py File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/17523/1/pySim-read.py@145 PS1, Line 145: (res, sw) = card.read_gid1() so the original code was reading GID2 and you're replacing it with reading gid1? I suppose this change should have happend in line 135, where GID1 is being read? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie96408b1eecd6fc2595d619f6f0e3af851dacecb Gerrit-Change-Number: 17523 Gerrit-PatchSet: 1 Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 19 Mar 2020 08:58:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200319/27d7e15b/attachment.htm>