Change in osmocom-bb[master]: trxcon/scheduler: TCH/F: fix Downlink burst completeness check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Mar 16 10:32:43 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17355 )

Change subject: trxcon/scheduler: TCH/F: fix Downlink burst completeness check
......................................................................

trxcon/scheduler: TCH/F: fix Downlink burst completeness check

A TCH/F or FACCH/F frame is interleaved over 8 bursts, not 4.

Change-Id: I2ee4a216a18e9b077b27887235d982481991d9c4
---
M src/host/trxcon/sched_lchan_tchf.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/host/trxcon/sched_lchan_tchf.c b/src/host/trxcon/sched_lchan_tchf.c
index 312425b..018b5e4 100644
--- a/src/host/trxcon/sched_lchan_tchf.c
+++ b/src/host/trxcon/sched_lchan_tchf.c
@@ -83,7 +83,7 @@
 	sched_trx_meas_avg(lchan, 8);
 
 	/* Check for complete set of bursts */
-	if ((*mask & 0xf) != 0xf) {
+	if ((*mask & 0xff) != 0xff) {
 		LOGP(DSCHD, LOGL_ERROR, "Received incomplete (%s) traffic frame at "
 			"fn=%u (%u/%u) for %s\n",
 			burst_mask2str(mask, 8), lchan->meas_avg.fn,

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17355
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I2ee4a216a18e9b077b27887235d982481991d9c4
Gerrit-Change-Number: 17355
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200316/a98f3d8c/attachment.htm>


More information about the gerrit-log mailing list