This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17476 ) Change subject: radioDevice: Drop unused isControl param from WriteSamples API ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/17476/1/Transceiver52M/device/usrp1/USRPDevice.cpp File Transceiver52M/device/usrp1/USRPDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/17476/1/Transceiver52M/device/usrp1/USRPDevice.cpp@519 PS1, Line 519: bool isControl > Is this argument really needed here? The function name explicitly states 'Control'. Well Precisely this function is the generic one being able to pass the extra isControl param, that's why I named it with Control at the end. if you feel better having another name for the function then provide one, but tbh being an internal private function I wouldn't care that much. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I843384e24b76cdd28a95f9ee4e95e6157098e4a3 Gerrit-Change-Number: 17476 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 13 Mar 2020 14:58:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200313/4821e124/attachment.htm>