Change in osmo-bsc[master]: osmo-bsc/bsc_vty: set default gprs cell bvci to 2

[osmith]

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17456 )

Change subject: osmo-bsc/bsc_vty: set default gprs cell bvci to 2
......................................................................

osmo-bsc/bsc_vty: set default gprs cell bvci to 2

Do not use 0 as default, as it is reserved for signalling.

Related: OS#4408
Change-Id: I499272f16aadd89f3bdb5d749e3e4f9e07056c15
---
M src/osmo-bsc/gsm_data.c
A tests/gprs_bvci_default.vty
2 files changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 90172dd..f12b032 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -807,6 +807,9 @@
 	memcpy(&bts->gprs.cell.rlc_cfg, &rlc_cfg_default,
 		sizeof(bts->gprs.cell.rlc_cfg));
 
+	/* 3GPP TS 08.18, chapter 5.4.1: 0 is reserved for signalling */
+	bts->gprs.cell.bvci = 2;
+
 	/* init statistics */
 	bts->bts_ctrs = rate_ctr_group_alloc(bts, &bts_ctrg_desc, bts->nr);
 	if (!bts->bts_ctrs) {
diff --git a/tests/gprs_bvci_default.vty b/tests/gprs_bvci_default.vty
new file mode 100644
index 0000000..4bd95ce
--- /dev/null
+++ b/tests/gprs_bvci_default.vty
@@ -0,0 +1,13 @@
+OsmoBSC> enable
+OsmoBSC# configure terminal
+OsmoBSC(config)# network
+OsmoBSC(config-net)# bts 0
+OsmoBSC(config-net-bts)# gprs mode gprs
+OsmoBSC(config-net-bts)# exit
+
+OsmoBSC(config-net)# show running-config
+...
+ bts 0
+...
+  gprs cell bvci 2
+...

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17456
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I499272f16aadd89f3bdb5d749e3e4f9e07056c15
Gerrit-Change-Number: 17456
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200312/5c132278/attachment.htm>