Change in osmo-bsc[master]: osmo-bsc/bsc_vty: set default gprs cell bvci to 2

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Mar 12 11:05:16 UTC 2020


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17456 )

Change subject: osmo-bsc/bsc_vty: set default gprs cell bvci to 2
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/17456/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/17456/1/src/osmo-bsc/bsc_vty.c@3064 
PS1, Line 3064: bts
> why not simply initialize this at the point where all other initializtaion of te 'bts' object is done, i.e. bts_init()?

Done.


> We can suppress printing the BVCI in 'save' while gprs.mode == NONE (in case that's what you're worried about).

I've verified that config_write_bts_gprs() returns without printing the BVCI if gprs.mode == NONE.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17456
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I499272f16aadd89f3bdb5d749e3e4f9e07056c15
Gerrit-Change-Number: 17456
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 12 Mar 2020 11:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200312/fb0f3db6/attachment.htm>


More information about the gerrit-log mailing list