Change in osmocom-bb[master]: trxcon/scheduler: be safe against a theoretical integer overflow

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Mar 11 11:08:30 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17449 )

Change subject: trxcon/scheduler: be safe against a theoretical integer overflow
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/17449/2/src/host/trxcon/sched_trx.c 
File src/host/trxcon/sched_trx.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17449/2/src/host/trxcon/sched_trx.c@725 
PS2, Line 725: 	if (++lchan->tdma.num_proc == 0) {
I'd be far more easier to understand having just one more boolean in struct tdma and using that when doing the initial check in subst_frame_loss(), but fine.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17449
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3d40ef09b06039a85df52af06ab38de314e1a434
Gerrit-Change-Number: 17449
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Mar 2020 11:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200311/31b03db2/attachment.htm>


More information about the gerrit-log mailing list