Change in osmo-msc[master]: fix segfault: unsolicited Paging Response

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Mar 9 21:23:17 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17441 )

Change subject: fix segfault: unsolicited Paging Response
......................................................................

fix segfault: unsolicited Paging Response

Do not crash when a Paging Response could not be associated with a VLR
subscriber.

Related: OS#4449
Change-Id: Ie117949dd6da86afaa1a0a6ac57bf2111f6cff43
---
M src/libmsc/paging.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/libmsc/paging.c b/src/libmsc/paging.c
index 743ce5c..b288414 100644
--- a/src/libmsc/paging.c
+++ b/src/libmsc/paging.c
@@ -137,6 +137,11 @@
 	struct paging_request *pr, *pr_next;
 	struct paging_signal_data sig_data;
 
+	if (!vsub) {
+		/* A Paging Response has no subscriber. (Related: OS#4449) */
+		return;
+	}
+
 	osmo_timer_del(&vsub->cs.paging_response_timer);
 
 	llist_for_each_entry_safe(pr, pr_next, &vsub->cs.requests, entry) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17441
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie117949dd6da86afaa1a0a6ac57bf2111f6cff43
Gerrit-Change-Number: 17441
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200309/f7d5b206/attachment.htm>


More information about the gerrit-log mailing list