Change in osmocom-bb[master]: trxcon/scheduler: substitute lost TDMA frames on Downlink

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 9 10:49:10 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17352 )

Change subject: trxcon/scheduler: substitute lost TDMA frames on Downlink
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/osmocom-bb/+/17352/4/src/host/trxcon/sched_trx.c 
File src/host/trxcon/sched_trx.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/17352/4/src/host/trxcon/sched_trx.c@622 
PS4, Line 622: 	if (lchan->tdma.num_proc == 0)
> On num_proc overflow you are gonna hit this again.
Given the frame duration and the limits of unsigned long...

  FRAME_DURATION = 4615 * 10e-6
  ULONG_MAX = 2 ^ 32

it would take:

  FRAME_DURATION * ULONG_MAX -> ~198212740.7 seconds
                          or -> ~55059.1 hours
                          or -> ~2294 days
                          or -> ~6 years.

Not sure if anybody on the earth would need to run trxcon for such a long time period :D


https://gerrit.osmocom.org/c/osmocom-bb/+/17352/4/src/host/trxcon/sched_trx.c@663 
PS4, Line 663: 		lchan->tdma.num_proc++;
> you probably don't need num_proc at all but simply a boolean to know if at least one was processed.
Yep, but I am planning to have some kind of statistics and print it from time to time.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17352
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3551d79796a3730565c2c70577e9d134e636f275
Gerrit-Change-Number: 17352
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Mar 2020 10:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200309/cbb1ad44/attachment.htm>


More information about the gerrit-log mailing list