Change in osmo-mgw[master]: Fix number of endpoints of default trunk

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Mar 8 09:52:05 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/17422 )


Change subject: Fix number of endpoints of default trunk
......................................................................

Fix number of endpoints of default trunk

If a config file doesn't have a 'number endpoints' config line,
we would use -1 as unsigned integer and end up with
 number endpoints 4294967295
if the config file is re-written

Change-Id: I05a3814117b1d6e0cdc30740da31709ce333df4b
Closes: OS#4034
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/22/17422/1

diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index c72596a..12fea1d 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -1620,7 +1620,7 @@
 
 	cfg->get_net_downlink_format_cb = &mgcp_get_net_downlink_format_default;
 
-	/* default trunk handling */
+	/* default trunk handling; TODO: avoid duplication with mgcp_trunk_alloc() below */
 	cfg->trunk.cfg = cfg;
 	cfg->trunk.trunk_nr = 0;
 	cfg->trunk.trunk_type = MGCP_TRUNK_VIRTUAL;
@@ -1628,6 +1628,7 @@
 	cfg->trunk.audio_payload = 126;
 	cfg->trunk.audio_send_ptime = 1;
 	cfg->trunk.audio_send_name = 1;
+	cfg->trunk.vty_number_endpoints = 33;
 	cfg->trunk.omit_rtcp = 0;
 	mgcp_trunk_set_keepalive(&cfg->trunk, MGCP_KEEPALIVE_ONCE);
 	if (alloc_mgcp_rate_counters(&cfg->trunk, cfg) < 0) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/17422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I05a3814117b1d6e0cdc30740da31709ce333df4b
Gerrit-Change-Number: 17422
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200308/0f2c3ef8/attachment.htm>


More information about the gerrit-log mailing list