Change in osmocom-bb[master]: virt_l1_sched_execute: talloc_free() TDMA item after unlinking it

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Mar 7 20:05:17 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17412 )

Change subject: virt_l1_sched_execute: talloc_free() TDMA item after unlinking it
......................................................................

virt_l1_sched_execute: talloc_free() TDMA item after unlinking it

We so far relied on it being free'd once the TDMA item is free'd,
but let's make it more explicit.  After we've unlinked it from the
list, nobody is going to reference it ever again.

Change-Id: I57a596428be10ce720e0b528ecfc44a70e3e3078
---
M src/host/virt_phy/src/virt_l1_sched_simple.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/host/virt_phy/src/virt_l1_sched_simple.c b/src/host/virt_phy/src/virt_l1_sched_simple.c
index a14a115..486d319 100644
--- a/src/host/virt_phy/src/virt_l1_sched_simple.c
+++ b/src/host/virt_phy/src/virt_l1_sched_simple.c
@@ -97,6 +97,7 @@
 				ti_next->handler_cb(ms, mi_next->fn, ti_next->ts, ti_next->msg);
 				/* remove handled tdma sched item */
 				llist_del(&ti_next->tdma_item_entry);
+				talloc_free(ti_next);
 			}
 			/* remove handled mframe sched item */
 			llist_del(&mi_next->mframe_item_entry);

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17412
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I57a596428be10ce720e0b528ecfc44a70e3e3078
Gerrit-Change-Number: 17412
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200307/228ba4c8/attachment.htm>


More information about the gerrit-log mailing list