This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17394 ) Change subject: csn1: fix csnStreamEncoder(): do not suppress 'no space' errors ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/17394/3/src/csn1.c File src/csn1.c: https://gerrit.osmocom.org/c/osmo-pcu/+/17394/3/src/csn1.c@1465 PS3, Line 1465: This patch doesn't look good to me. This section you are removing looks like the base case for the recursion, and you are changing the behavior here, since it will go through all the code at least once (due to loop being a do-while). That doesn't make sense since in here at the start we know we hit an error (negative number of bites) or we simply reached the end, so we are done. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie3a15e210624599e39b1e70c8d34efc10c552f6c Gerrit-Change-Number: 17394 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2020 23:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200306/fecbe8b2/attachment.htm>