This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore.git/+/17331 ) Change subject: gb: Logging improvements. ...................................................................... Patch Set 1: Code-Review-1 (2 comments) unless I'm missing something, this actually removes useful features (like sending a NS-STATUS in response to the unexpected NS-ALIVE) and just moves the loggign around? https://gerrit.osmocom.org/c/libosmocore.git/+/17331/1/src/gb/gprs_ns.c File src/gb/gprs_ns.c: https://gerrit.osmocom.org/c/libosmocore.git/+/17331/1/src/gb/gprs_ns.c@321 PS1, Line 321: %d, Data weight % formally correct would be %u as it's unsigned integers. Sure, with uint8_t an int should never overflow, so no practical issue. https://gerrit.osmocom.org/c/libosmocore.git/+/17331/1/src/gb/gprs_ns.c@1678 PS1, Line 1678: return GPRS_NS_CS_REJECTED; > I'm just trying to understand the patch in relation to your issue description. […] I agree with pespin here, from INFO level it should have shown up exactly in line 1655 above "Rejecting NS PDU type ...". The advantage of the old log line is that you could use the log filters (as it sets the nsvc context). Also, it actually returns a NS-STATUS informing the peer about the cause of the reject. -- To view, visit https://gerrit.osmocom.org/c/libosmocore.git/+/17331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore.git Gerrit-Branch: master Gerrit-Change-Id: Ic145bcc54e3f0779ea9e284216831b17ab22eb91 Gerrit-Change-Number: 17331 Gerrit-PatchSet: 1 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 03 Mar 2020 16:23:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: ipse <Alexander.Chemeris at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200303/427b1b52/attachment.htm>