Change in libosmocore.git[master]: gb: Logging improvements.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Tue Mar 3 15:32:14 UTC 2020


ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore.git/+/17331 )

Change subject: gb: Logging improvements.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore.git/+/17331/1/src/gb/gprs_ns.c 
File src/gb/gprs_ns.c:

https://gerrit.osmocom.org/c/libosmocore.git/+/17331/1/src/gb/gprs_ns.c@1678 
PS1, Line 1678: 		return GPRS_NS_CS_REJECTED;
> iiuc it was returning over this path before? so it wasn't silently ignored.
In practice, it was ignored silently, i.e. no error messages were sent. I guess because an NSVC is not yet established, so we don't know where to send them. But I haven't bug into this deep - I just observed this in Wireshark. We can change the return code above to GPRS_NS_CS_REJECTED if you think it makes more sense in the cases I haven't observed.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore.git/+/17331
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore.git
Gerrit-Branch: master
Gerrit-Change-Id: Ic145bcc54e3f0779ea9e284216831b17ab22eb91
Gerrit-Change-Number: 17331
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Mar 2020 15:32:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200303/fa0b9604/attachment.htm>


More information about the gerrit-log mailing list