Change in osmo-ccid-firmware[master]: generic improvements for the testsbed

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

roh gerrit-no-reply at lists.osmocom.org
Tue Mar 3 12:54:03 UTC 2020


roh has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257 )

Change subject: generic improvements for the testsbed
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1//COMMIT_MSG@7 
PS1, Line 7: generic improvements for the testsbed:
> first line of the commit log message should be brief one-line summary followed by empty line before  […]
done


https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/05_flash_dfu_from_app.out 
File tests/sysmo-octsim/05_flash_dfu_from_app.out:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/05_flash_dfu_from_app.out@12 
PS1, Line 12: Run-time device DFU version 0100
> this kind of matching of the full stdout will break every time the distribution updates dfu-util... […]
i think this is ok, since we do not update that often (0.9 is in there for ages) and the output lets us find out which way dfu was run (from app mode or from bootloader - we test both)


https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/05_flash_dfu_from_app.sh 
File tests/sysmo-octsim/05_flash_dfu_from_app.sh:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/05_flash_dfu_from_app.sh@3 
PS1, Line 3: 
> is it intentional that we continue this script even if one of the called scripts return error?  Othe […]
changed all scripts but the main testwalker to use set -e



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I246224e29e5936b4fe40cf7d7a5ff83c9940d121
Gerrit-Change-Number: 17257
Gerrit-PatchSet: 2
Gerrit-Owner: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 03 Mar 2020 12:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200303/6457253a/attachment.htm>


More information about the gerrit-log mailing list