Change in simtrace2[master]: cardem: Fix infinite loop + watchdog reset on long OUT message

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/17305 )

Change subject: cardem: Fix infinite loop + watchdog reset on long OUT message
......................................................................

cardem: Fix infinite loop + watchdog reset on long OUT message

In dispatch_received_usb_msg(), we ran into an infinite loop if a
too long messages was received on the OUT EP.  Let's break the loop.

Change-Id: I5325ed15d3dd79a42f8dac34d618e86b9334c301
Closes: OS#4429
---
M firmware/libcommon/source/mode_cardemu.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c
index c5c173f..5b17f86 100644
--- a/firmware/libcommon/source/mode_cardemu.c
+++ b/firmware/libcommon/source/mode_cardemu.c
@@ -682,6 +682,7 @@
 			TRACE_ERROR("%u: Unexpected large message (%u bytes)\n",
 					ci->num, mh->msg_len);
 			usb_buf_free(segm);
+			break;
 		} else {
 			uint8_t *cur = msgb_put(segm, mh->msg_len);
 			segm->l1h = segm->head;

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/17305
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I5325ed15d3dd79a42f8dac34d618e86b9334c301
Gerrit-Change-Number: 17305
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200302/f005059e/attachment.htm>