Change in osmo-pcu[master]: llc_queue::{dequeue,enqueue}() refactor

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 2 09:49:24 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17282 )

Change subject: llc_queue::{dequeue,enqueue}() refactor
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17282/1/tests/llc/LlcTest.cpp 
File tests/llc/LlcTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17282/1/tests/llc/LlcTest.cpp@77 
PS1, Line 77: &&
            : 			    memcmp(&exp_info->expire_time, &info_res->expire_time, sizeof(info_res->expire_time)) == 0
> Rather move this into a separate OSMO_ASSERT statement.
What do you mean? Having an assert for each memcmp?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17282
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ief6b1464dc779ff22adc2b02da7a006cd772ebce
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Mar 2020 09:49:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200302/52d57da5/attachment.htm>


More information about the gerrit-log mailing list