Change in osmo-gsm-tester[master]: {ms, enb}_srs: add method to read kpi from a test run

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986 )

Change subject: {ms,enb}_srs: add method to read kpi from a test run
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/2/src/osmo_gsm_tester/obj/srslte_common.py 
File src/osmo_gsm_tester/obj/srslte_common.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/2/src/osmo_gsm_tester/obj/srslte_common.py@24 
PS2, Line 24:   def __init__(self, name, run_dir):
You don't seem to be using this run_dir.
BTW, you should be calling the log.Origin constructor here, check how other classes do it.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/2/src/osmo_gsm_tester/obj/srslte_common.py@34 
PS2, Line 34:           # Please make sure the srsLTE scripts folder is included in your PYTHONPATH env variable
shipped with srsLTE means srsLTE.git? if so write "srsLTE.git" there, or explain a bit better please.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I28226a375f9ac4e08424c488062ae6a74a19af92
Gerrit-Change-Number: 18986
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jun 2020 12:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200630/f20f38ce/attachment.htm>