This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19043 ) Change subject: ctl.c: Fix off-by-one: FD=0 is a valid file descriptor ...................................................................... ctl.c: Fix off-by-one: FD=0 is a valid file descriptor It is possible that fd=0 (stdin) is closed in a daemon scenario, and subsequently fd=0 is reused for other files/sockets. Change-Id: Id8279f04373e891009224bab34a4d1d886520fea --- M src/ctl.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve tnt: Looks good to me, approved diff --git a/src/ctl.c b/src/ctl.c index a70556d..dd9155d 100644 --- a/src/ctl.c +++ b/src/ctl.c @@ -96,7 +96,7 @@ { ts->mode = E1_TS_MODE_OFF; - if (ts->fd > 0) { + if (ts->fd >= 0) { close(ts->fd); ts->fd = -1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id8279f04373e891009224bab34a4d1d886520fea Gerrit-Change-Number: 19043 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Assignee: tnt <tnt at 246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200630/e6c69248/attachment.htm>