Change in osmo-e1d[master]: close timeslot socket if read or write returns negative

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Mon Jun 29 20:55:21 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19056 )

Change subject: close timeslot socket if read or write returns negative
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-e1d/+/19056/1/src/intf_line.c 
File src/intf_line.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/19056/1/src/intf_line.c@150 
PS1, Line 150: 				e1_ts_stop(ts);
I think the e1_ts_stop should be in the caller.
Just return -1 in the helper and leave the choice to the caller how to deal with the failure.

ATM there is a check for if (l <= 0) continue, I guess I'd add it as a case here that if < 0 then e1_ts_stop (which handles both the HDLC and RAW case at once too).

Same remark for the other instances.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19056
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I2e3e5010f36e916b4c8908af91447b3d3661123f
Gerrit-Change-Number: 19056
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Mon, 29 Jun 2020 20:55:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/40d5ee76/attachment.htm>


More information about the gerrit-log mailing list