This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
tnt gerrit-no-reply at lists.osmocom.orgtnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19033 ) Change subject: remove code not specific to USB from usb.c to intf_line.c ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment) https://gerrit.osmocom.org/c/osmo-e1d/+/19033/2/src/e1d.h File src/e1d.h: https://gerrit.osmocom.org/c/osmo-e1d/+/19033/2/src/e1d.h@85 PS2, Line 85: e1_intf_new( > actually if the naming conventions as I undertand it so far were strictly followed, it would have to […] Well the intent when I first thought of it, and how it turned out due to the reality of things beings not entirely separate and inevitably connected is probably how it ended up that way. So I'm fine with dropped e1d_ all together really and just have the e1_daemon_new_intf / e1_intf_new_line / ... to have things more consistent with the "object model". Also some of the names being static / file-local I probably took liberties that I wouldn't do in a more global scope. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I7d4d4ab39cb3e7e6a7eb8e738a367122eb3fbee2 Gerrit-Change-Number: 19033 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Assignee: tnt <tnt at 246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-Comment-Date: Mon, 29 Jun 2020 15:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/9788b388/attachment.htm>