Change in osmo-e1d[master]: add _e1d_line_destroy() / _e1d_intf_destroy() functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Jun 29 15:04:59 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19045 )

Change subject: add _e1d_line_destroy() / _e1d_intf_destroy() functions
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-e1d/+/19045/1/src/intf_line.c 
File src/intf_line.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/19045/1/src/intf_line.c@71 
PS1, Line 71: _e1_intf_destroy(struct e1_intf *intf)
> Also, I'm getting a bit confused about the e1_ vs e1d_ prefix and what belongs where logically.
> (I'm just looking at the individual patches ATM so I don't have a clear view of the final code organization).

I'm confused about the naming in the original code, where some functions have e1d_ prefix and some have e1_ prefix.   I think it would make sense to call everything e1d_* prefix if it is inside the daaemon while other code just has e1_ prefix.

For now I will use e1d_ prefix only if the first argument is a 'struct e1_daemon', and use e1_ts / e1_intf / e1_line prefix for the respective other first arguments.

> But obviously it's confusing since the commit title uses e1d_ and the function is actually e1_ ...

Agreed, will change that.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19045
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I5425d22288d7239063d621bddfe81e9cf21f1a5b
Gerrit-Change-Number: 19045
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Mon, 29 Jun 2020 15:04:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/6618138f/attachment.htm>


More information about the gerrit-log mailing list