Change in osmo-trx[master]: UHDDevice: Implement getNominalTxPower() based on TxFrequency

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18721 )

Change subject: UHDDevice: Implement getNominalTxPower() based on TxFrequency
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/18721/2/Transceiver52M/device/uhd/UHDDevice.cpp 
File Transceiver52M/device/uhd/UHDDevice.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/18721/2/Transceiver52M/device/uhd/UHDDevice.cpp@1029 
PS2, Line 1029: if (band != 0 && req_band != band) {
Hi Pau,

this patch, in particular this (req_band != band) check, makes it impossible to change an ARFCN from one band to an ARFCN from another band in osmo-bsc/osmo-bts-trx without restarting osmo-trx-uhd. I faced this a few minutes ago, and it took me a while to investigate/realize this.

Why do we need this check? I could not find any explanation in the commit message, nor any comments in the code why the new freq. band shall be the same as was used before? To me it looks like we don't need this check at all. If I am wrong, please add some comments and update documentation, so another user facing this error message would not need to read the source code and bisect git history.

Thanks.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18721
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If7ef5bf95ffe4afe5864c0f051853aa38b9639eb
Gerrit-Change-Number: 18721
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sat, 27 Jun 2020 11:58:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200627/e7364e07/attachment.htm>