This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19011 ) Change subject: osmo-bts-trx/scheduler: get rid of _sched_fcch_burst ...................................................................... Patch Set 2: > Patch Set 2: > > > Patch Set 2: > > > > the question is: *if* you want to remove one of the memset-zero, wouldn't it be more logical to remove the one that initializes br->burst to zero and keep the memcpy/memset here? > > If you mean removing the memzero from msgb, I'm in favour, but that's probably going to break some existing code :P Actually, in the current code the burst buffer is allocated on stack [1] and then implicitly zero-initialized [2] by structure assignment. I would prefer to keep the implicit initialization, so we don't have to memset() tail bits in each lchan handler. [1] https://git.osmocom.org/osmo-bts/tree/src/osmo-bts-trx/scheduler_trx.c#n61 [2] https://git.osmocom.org/osmo-bts/tree/src/osmo-bts-trx/scheduler_trx.c#n90 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic4f6d550010da5caf4bc471ff1e184c9fab30c6d Gerrit-Change-Number: 19011 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 26 Jun 2020 14:15:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200626/671550ae/attachment.htm>