Change in libosmo-sccp[master]: add osmo_ss7_instance_asp_find_by_proto()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Fri Jun 26 13:51:22 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/19012 )

Change subject: add osmo_ss7_instance_asp_find_by_proto()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/19012/1/src/osmo_ss7.c 
File src/osmo_ss7.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/19012/1/src/osmo_ss7.c@1290 
PS1, Line 1290:  *  \param[in] match_idx  return Nth matching ASP, 0 to return first match.
> I'm wondering what's the point about using this Nth stuff, why would you use that? sounds wrong to m […]
the idea is that an ASP matching a proto may have some reason why the caller doesn't want to use it, so instead find the next one.

but iterate directly, yea... the caller I have in mind is sccp_user.c, I assumed some opaque API would prevent accessing directly, but that is actually not the case. Dropping this patch.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/19012
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ib204c6906eb02fe64b43b75375e1b69e2a8abd30
Gerrit-Change-Number: 19012
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Jun 2020 13:51:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200626/5689a8e5/attachment.htm>


More information about the gerrit-log mailing list