Change in osmo-ttcn3-hacks[master]: msc: verify conn and VLR cell id in most tests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Fri Jun 26 12:54:37 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998 )

Change subject: msc: verify conn and VLR cell id in most tests
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998/1//COMMIT_MSG@7 
PS1, Line 7: in most tests
> Does it really make sense to verify it in all test cases? Why not to implement a dedicated test case […]
I would need to set up various kinds of level 3 complete and see whether each one ends up saving the cell id. Instead I decided to use the tests we already have to avoid code dup and make the feature universally tested.

The down side is that each test that wants a complete l3 to fail needs to indicate that it doesn't expect the cell id to propagate.

But this is a bit like the Codec List (BSS Supported), or whether Osmux is indicated: I'd rather make it part of all the tests because it is a detail present in "every" situation.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18998
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie410714a96353f74a52a104c56fa0a08683e0004
Gerrit-Change-Number: 18998
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Jun 2020 12:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200626/78e3604e/attachment.htm>


More information about the gerrit-log mailing list