Change in osmo-bts[master]: Fix shutdown in osmo-bts-{omldummy, virtual}

[neels]

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19006 )

Change subject: Fix shutdown in osmo-bts-{omldummy,virtual}
......................................................................

Fix shutdown in osmo-bts-{omldummy,virtual}

Change-Id: Idadb62ec25181b140d9061dc7470da00d47d8336
---
M include/osmo-bts/bts_model.h
M src/osmo-bts-omldummy/bts_model.c
M src/osmo-bts-virtual/bts_model.c
3 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  neels: Looks good to me, approved



diff --git a/include/osmo-bts/bts_model.h b/include/osmo-bts/bts_model.h
index f62291c..4fd0813 100644
--- a/include/osmo-bts/bts_model.h
+++ b/include/osmo-bts/bts_model.h
@@ -43,6 +43,7 @@
 
 int bts_model_oml_estab(struct gsm_bts *bts);
 
+/* Implementation should call power_trx_change_compl() to confirm power change applied */
 int bts_model_change_power(struct gsm_bts_trx *trx, int p_trxout_mdBm);
 int bts_model_adjst_ms_pwr(struct gsm_lchan *lchan);
 
diff --git a/src/osmo-bts-omldummy/bts_model.c b/src/osmo-bts-omldummy/bts_model.c
index dc0e041..c31354f 100644
--- a/src/osmo-bts-omldummy/bts_model.c
+++ b/src/osmo-bts-omldummy/bts_model.c
@@ -158,7 +158,7 @@
 
 int bts_model_change_power(struct gsm_bts_trx *trx, int p_trxout_mdBm)
 {
-	LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__);
+	power_trx_change_compl(trx, p_trxout_mdBm);
 	return 0;
 }
 
diff --git a/src/osmo-bts-virtual/bts_model.c b/src/osmo-bts-virtual/bts_model.c
index 8209ce2..dfce81f 100644
--- a/src/osmo-bts-virtual/bts_model.c
+++ b/src/osmo-bts-virtual/bts_model.c
@@ -175,6 +175,7 @@
 int bts_model_change_power(struct gsm_bts_trx *trx, int p_trxout_mdBm)
 {
 	LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__);
+	power_trx_change_compl(trx, p_trxout_mdBm);
 	return 0;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19006
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idadb62ec25181b140d9061dc7470da00d47d8336
Gerrit-Change-Number: 19006
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200625/4e04b277/attachment.htm>