This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/18995 ) Change subject: add comments to clarify some complete l3 details ...................................................................... add comments to clarify some complete l3 details Change-Id: I6e289900d38d97c346d615b71d36656254e6f2b5 --- M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/95/18995/1 diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index a70c4b9..15303b5 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -1396,7 +1396,9 @@ msub_update_id(msub); } -/* VLR informs us that the subscriber has been associated with a conn */ +/* VLR informs us that the subscriber has been associated with a conn. + * The subscriber has *not* been authenticated yet, so the vsub should be protected from potentially invalid information + * from the msc_a. */ static int msc_vlr_subscr_assoc(void *msc_conn_ref, struct vlr_subscr *vsub) { @@ -1406,6 +1408,10 @@ if (msub_set_vsub(msub, vsub)) return -EINVAL; + + /* FIXME: would be better to modify vsub->* only after the subscriber is authenticated, in + * evaluate_acceptance_outcome(conn_accepted == true). */ + vsub->cs.attached_via_ran = msc_a->c.ran->type; /* In case we have already received Classmark Information before the VLR Subscriber was diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 3bfc0f8..fd66ad3 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1375,6 +1375,8 @@ switch (msg->msg_type) { case RAN_MSG_COMPL_L3: + /* In case the cell_id from Complete Layer 3 Information lacks a PLMN, write the configured PLMN code + * into msc_a->via_cell. Then overwrite with those bits obtained from Complete Layer 3 Information. */ msc_a->via_cell = (struct osmo_cell_global_id){ .lai.plmn = msc_a_net(msc_a)->plmn, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6e289900d38d97c346d615b71d36656254e6f2b5 Gerrit-Change-Number: 18995 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200624/80d0b9f6/attachment.htm>