Change in osmo-bsc[master]: vty/bts_resend_cmd: Use gsm_bts_set_system_infos() to increment chang...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jun 24 05:25:58 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18938 )

Change subject: vty/bts_resend_cmd: Use gsm_bts_set_system_infos() to increment changemark
......................................................................

vty/bts_resend_cmd: Use gsm_bts_set_system_infos() to increment changemark

We assume the SI shall be re-sent because something has changed.  This
means that change_mark should be incremented.  Let's call
gsm_bts_set_system_infos() which already does the trick.

Change-Id: I73d9bd3cddc561f3a7af8bcc225fac126dca3f78
Closes: OS#3679
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 2941e5b..f46a84c 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4764,7 +4764,6 @@
       "Re-generate + re-send BCCH SYSTEM INFORMATION\n")
 {
 	struct gsm_network *gsmnet;
-	struct gsm_bts_trx *trx;
 	struct gsm_bts *bts;
 	unsigned int bts_nr;
 
@@ -4783,8 +4782,7 @@
 		return CMD_WARNING;
 	}
 
-	llist_for_each_entry_reverse(trx, &bts->trx_list, list)
-		gsm_bts_trx_set_system_infos(trx);
+	gsm_bts_set_system_infos(bts);
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18938
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I73d9bd3cddc561f3a7af8bcc225fac126dca3f78
Gerrit-Change-Number: 18938
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200624/18b8d065/attachment.htm>


More information about the gerrit-log mailing list