Change in osmo-ttcn3-hacks[master]: bts: Introduce TC_tx_power_ramp_adm_state_change

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Jun 23 20:14:58 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18991 )

Change subject: bts: Introduce TC_tx_power_ramp_adm_state_change
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18991/1/bts/BTS_Tests.ttcn 
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18991/1/bts/BTS_Tests.ttcn@2219 
PS1, Line 2219:  * + ramping up during ADM state LOCKED->UNLOCKED
(the '+' are bullet points?)


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18991/1/bts/BTS_Tests.ttcn@2241 
PS1, Line 2241: 	 *anymore because scheduler has stopped after ramping down */
(space after *)


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18991/1/bts/BTS_Tests.ttcn@2257 
PS1, Line 2257: 	f_verify_ramp_up();
seems that setverdict(pass) is missing here ... I'd actually expect an f_verify_* function to include a setverdict(pass) (and fail) but looks like it doesn't



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18991
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I03efdfe19e9cecadb0d03811a7029b54bf6281da
Gerrit-Change-Number: 18991
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jun 2020 20:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/34df0917/attachment.htm>


More information about the gerrit-log mailing list